Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add markdown document for command detection framework #321

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

congqixia
Copy link
Collaborator

Add document for command detction framework:

  • naming rules
  • signature rules
  • embedding struct

Add document for command detction framework:

- naming rules
- signature rules
- embedding struct

Signed-off-by: Congqi Xia <[email protected]>
@czs007
Copy link
Contributor

czs007 commented Oct 16, 2024

/approve
/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Oct 16, 2024
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 020b4c0 into milvus-io:v1.0.x Oct 16, 2024
3 checks passed
@congqixia congqixia added the kind/documentation Improvements or additions to documentation label Oct 17, 2024
@congqixia congqixia deleted the doc/bw_command_framework branch October 17, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed kind/documentation Improvements or additions to documentation lgtm look good to me size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants