Service port name template according to Istio naming convention (#451)

Signed-off-by: Gleb Vazhenin <[email protected]>
milvus-io · Jun 13, 2023 · cb83653 · cb83653
1 parent 029e012
commit cb83653
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 3 deletions.
diff --git a/charts/milvus/Chart.yaml b/charts/milvus/Chart.yaml
@@ -3,7 +3,7 @@ name: milvus
 appVersion: "2.2.9"
 kubeVersion: "^1.10.0-0"
 description: Milvus is an open-source vector database built to power AI applications and vector similarity search.
-version: 4.0.23
+version: 4.0.24
 keywords:
   - milvus
   - elastic

diff --git a/charts/milvus/README.md b/charts/milvus/README.md
@@ -161,6 +161,7 @@ The following table lists the configurable parameters of the Milvus Service and
 | `extraConfigFiles`                        | Extra config to override default milvus.yaml  | `user.yaml:`                                                     |
 | `service.type`                            | Service type                                  | `ClusterIP`                                             |
 | `service.port`                            | Port where service is exposed                 | `19530`                                                 |
+| `service.portName`                        | Useful for [Istio protocol selection](https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/)   | `milvus`                                                |
 | `service.nodePort`                        | Service nodePort                              | `unset`                                                 |
 | `service.annotations`                     | Service annotations                           | `{}`                                                    |
 | `service.labels`                          | Service custom labels                         | `{}`                                                    |

diff --git a/charts/milvus/templates/service.yaml b/charts/milvus/templates/service.yaml
@@ -36,7 +36,7 @@ spec:
   type: {{ .Values.service.type }}
 {{- end }}
   ports:
-    - name: milvus
+    - name: {{ .Values.service.portName }}
       port: {{ .Values.service.port }}
       protocol: TCP
       targetPort: milvus
@@ -56,4 +56,4 @@ spec:
 {{- else if and .Values.proxy.enabled .Values.cluster.enabled }}
     component: "proxy"
 {{- end }}
-{{- end }}
+{{- end }}
diff --git a/charts/milvus/values.yaml b/charts/milvus/values.yaml
@@ -58,6 +58,7 @@ extraConfigFiles:
 service:
   type: ClusterIP
   port: 19530
+  portName: milvus
   nodePort: ""
   annotations: {}
   labels: {}