fix: perf issue, do not load proto on each search() call #124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
I wanted to use this client for a project, but the problem is it's extremely slow because it loads proto on each
search()
call which takes around 40ms just to load proto.Here's a benchmark, it's a simple nodejs server that uses milvus client to search:
Dataset
id as varchar 24, and float vector with 128 dimensions, 500K vectors.
Env:
CPU AMD Ryzen 3900X
32GB ram DDR4
SSD 512GB WD black PCIe 4.0 m2
Results
I think it's speaks for itself :)