Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support expr for count #274

Merged
merged 4 commits into from
Jan 23, 2024
Merged

support expr for count #274

merged 4 commits into from
Jan 23, 2024

Conversation

shanghaikid
Copy link
Contributor

No description provided.

Signed-off-by: ryjiang <[email protected]>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: ryjiang <[email protected]>
Signed-off-by: ryjiang <[email protected]>
Signed-off-by: ryjiang <[email protected]>
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (99f9ece) 93.77% compared to head (4eab1e9) 96.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
+ Coverage   93.77%   96.84%   +3.06%     
==========================================
  Files          38       39       +1     
  Lines        1831     1901      +70     
  Branches      458      460       +2     
==========================================
+ Hits         1717     1841     +124     
+ Misses        109       55      -54     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shanghaikid shanghaikid merged commit 040ccf0 into main Jan 23, 2024
4 of 5 checks passed
@shanghaikid shanghaikid deleted the count branch January 23, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants