Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: queryIterator limit field should be optional #361

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

shanghaikid
Copy link
Contributor

this related to #360

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shanghaikid

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.09%. Comparing base (9d4cc1b) to head (fed1212).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #361   +/-   ##
=======================================
  Coverage   97.08%   97.09%           
=======================================
  Files          43       43           
  Lines        2712     2715    +3     
  Branches      674      675    +1     
=======================================
+ Hits         2633     2636    +3     
  Misses         75       75           
  Partials        4        4           
Flag Coverage Δ
97.09% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shanghaikid shanghaikid merged commit d9c4aaf into main Sep 26, 2024
4 of 5 checks passed
@shanghaikid shanghaikid deleted the node-360 branch September 26, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants