Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support submodule for milvus proto #89

Merged
merged 3 commits into from
Mar 19, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ jobs:
wget https://raw.githubusercontent.com/milvus-io/milvus/master/deployments/docker/standalone/docker-compose.yml -O docker-compose.yml
docker-compose up -d

- name: update submodules
run: |
git submodule init
git submodule update --remote

- name: Run Test coverage
run: |
yarn
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ jobs:

- name: Install dependencies
run: yarn

- name: update submodules
run: |
git submodule init
git submodule update --remote

- name: Build app
run: |
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ jobs:
run: |
wget https://raw.githubusercontent.com/milvus-io/milvus/master/deployments/docker/standalone/docker-compose.yml -O docker-compose.yml
docker-compose up -d

- name: update submodules
run: |
git submodule init
git submodule update --remote

- name: Run Test coverage
run: |
Expand Down
3 changes: 3 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[submodule "proto"]
path = proto
url = https://github.com/milvus-io/milvus-proto.git
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ Node: v12+
| compact | true | Do compaction for the collection |
| getCompactionState | true | Get compaction states by compact id |

## How to dev
1. yarn
2. git submodule init (if this is your first time)
3. git submodule update --remote
4. In milvus folder has all milvus related functions.
## Example

1. [Hello World](https://github.com/milvus-io/milvus-sdk-node/blob/main/example/HelloMilvus.ts)
Expand Down
6 changes: 4 additions & 2 deletions build.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@ function copyFileSync(source, target) {

function copyFolderRecursiveSync(source, target) {
let files = [];

if (!fs.existsSync(target)){
fs.mkdirSync(target, { recursive: true });
}
// Check if folder needs to be created or integrated
let targetFolder = path.join(target, path.basename(source));
if (!fs.existsSync(targetFolder)) {
Expand Down Expand Up @@ -65,7 +67,7 @@ function writeSdkJson(path) {
}
}

copyFolderRecursiveSync("./grpc-proto", "./dist");
copyFolderRecursiveSync("./proto/proto", "./dist/proto");

// if dist has package.json need delete it.
// otherwise npm publish will use package.json inside dist then will missing files.
Expand Down
201 changes: 0 additions & 201 deletions grpc-proto/common.proto

This file was deleted.

Loading