Skip to content

Commit

Permalink
Remove unnecessary interface declarations
Browse files Browse the repository at this point in the history
Signed-off-by: Ted Xu <[email protected]>
  • Loading branch information
tedxu committed Apr 10, 2024
1 parent dea149c commit 5c0e0c8
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions internal/storage/serde.go
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,9 @@ func (r *compositeRecord) Schema() map[FieldID]schemapb.DataType {
return r.schema
}

var _ RecordReader = (*compositeRecordReader)(nil)

type compositeRecordReader struct {
RecordReader
blobs [][]*Blob

blobPos int
Expand Down Expand Up @@ -665,10 +666,10 @@ func NewBinlogDeserializeReader(blobs []*Blob, PKfieldID UniqueID) (*Deserialize
}), nil
}

var _ Record = (*selectiveRecord)(nil)

// selectiveRecord is a Record that only contains a single field, reusing existing Record.
type selectiveRecord struct {
Record

r Record
selectedFieldId FieldID

Expand Down Expand Up @@ -708,8 +709,9 @@ func newSelectiveRecord(r Record, selectedFieldId FieldID) *selectiveRecord {
}
}

var _ RecordWriter = (*compositeRecordWriter)(nil)

type compositeRecordWriter struct {
RecordWriter
writers map[FieldID]RecordWriter
}

Expand Down Expand Up @@ -742,8 +744,9 @@ func newCompositeRecordWriter(writers map[FieldID]RecordWriter) *compositeRecord
}
}

var _ RecordWriter = (*singleFieldRecordWriter)(nil)

type singleFieldRecordWriter struct {
RecordWriter
fw *pqarrow.FileWriter
fieldId FieldID

Expand Down

0 comments on commit 5c0e0c8

Please sign in to comment.