Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: support NOT LIKE expr #36725

Open
1 task done
zhagnlu opened this issue Oct 10, 2024 · 2 comments · May be fixed by #37378
Open
1 task done

[Enhancement]: support NOT LIKE expr #36725

zhagnlu opened this issue Oct 10, 2024 · 2 comments · May be fixed by #37378
Assignees
@zhagnlu
Labels
kind/enhancement Issues or changes related to enhancement

Comments

@zhagnlu
Copy link
Contributor

zhagnlu commented Oct 10, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

now, milvus not support "not like" expr

Why is this needed?

No response

Anything else?

No response
@zhagnlu zhagnlu added the kind/enhancement Issues or changes related to enhancement label Oct 10, 2024
@zhagnlu zhagnlu self-assigned this Oct 10, 2024
@Sayed-Ameer
Copy link

Sayed-Ameer commented Oct 20, 2024 •
edited
Loading

I just realized also NOT LIKE expr doesn't work, any ETA for it to work?

@xiaofan-luan
Copy link
Collaborator

@zhagnlu is working on that and ideally it shouldn't take too long

jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Nov 1, 2024
@jiangyinzuo
feat: support not like expr
c4c240d 
UnaryRange expr now suports `PrefixMatch`, `PrefixNotMatch`, `Match` and
`NotMatch` operator. In this way, `... not like ...` expr should be
faster than `not ... like ...` expr, it fuses `not` and `like` exprs.

closes: milvus-io#36725

Signed-off-by: Yinzuo Jiang <[email protected]>
Signed-off-by: Yinzuo Jiang <[email protected]>
@jiangyinzuo jiangyinzuo linked a pull request Nov 1, 2024 that will close this issue
Draft
jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Nov 1, 2024
@jiangyinzuo
feat: support not like expr
bf8ba78 
UnaryRange expr now suports `PrefixMatch`, `PrefixNotMatch`, `Match` and
`NotMatch` operator. In this way, `... not like ...` expr should be
faster than `not ... like ...` expr, it fuses `not` and `like` exprs.

closes: milvus-io#36725

Signed-off-by: Yinzuo Jiang <[email protected]>
Signed-off-by: Yinzuo Jiang <[email protected]>
jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Nov 1, 2024
@jiangyinzuo
feat: support not like expr
aa103ad 
UnaryRange expr now suports `PrefixMatch`, `PrefixNotMatch`, `Match` and
`NotMatch` operator. In this way, `... not like ...` expr should be
faster than `not ... like ...` expr, it fuses `not` and `like` exprs.

closes: milvus-io#36725

Signed-off-by: Yinzuo Jiang <[email protected]>
Signed-off-by: Yinzuo Jiang <[email protected]>
jiangyinzuo added a commit to jiangyinzuo/milvus that referenced this issue Nov 1, 2024
@jiangyinzuo
feat: support not like expr
be1f2a1 
UnaryRange expr now suports `PrefixMatch`, `PrefixNotMatch`, `Match` and
`NotMatch` operator. In this way, `... not like ...` expr should be
faster than `not ... like ...` expr, it fuses `not` and `like` exprs.

closes: milvus-io#36725

Signed-off-by: Yinzuo Jiang <[email protected]>
Signed-off-by: Yinzuo Jiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhagnlu zhagnlu

Labels
kind/enhancement Issues or changes related to enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support not like expr jiangyinzuo/milvus
3 participants
@zhagnlu @xiaofan-luan @Sayed-Ameer