Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: refactor createIndex in RESTful API #37235

Merged
merged 1 commit into from
Nov 7, 2024
Merged

enhance: refactor createIndex in RESTful API #37235

merged 1 commit into from
Nov 7, 2024

Conversation

smellthemoon
Copy link
Contributor

Make the parameter input method consistent with miluvs-client.

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Oct 29, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 29, 2024
@smellthemoon smellthemoon mentioned this pull request Oct 29, 2024
Closed
smellthemoon pushed a commit to smellthemoon/milvus that referenced this pull request Oct 29, 2024
enhance: refactor createIndex in RESTful API(milvus-io#37235)
2ac8026 
Signed-off-by: lixinguo <[email protected]>
smellthemoon pushed a commit to smellthemoon/milvus that referenced this pull request Oct 29, 2024
enhance: refactor createIndex in RESTful API(milvus-io#37235)
c62ebce 
Signed-off-by: lixinguo <[email protected]>
@smellthemoon smellthemoon mentioned this pull request Oct 29, 2024
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

smellthemoon pushed a commit to smellthemoon/milvus that referenced this pull request Oct 29, 2024
enhance: refactor createIndex in RESTful API(milvus-io#37235)
1131a8a 
Signed-off-by: lixinguo <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.10%. Comparing base (b83b376) to head (7596068).
Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
...nternal/distributed/proxy/httpserver/handler_v2.go 20.00% 7 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37235      +/-   ##
==========================================
- Coverage   83.26%   79.10%   -4.16%     
==========================================
  Files        1015     1297     +282     
  Lines      157473   181709   +24236     
==========================================
+ Hits       131115   143737   +12622     
- Misses      21166    32803   +11637     
+ Partials     5192     5169      -23
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.17% <ø> (∅)
Go 81.04% <46.66%> (-2.25%) ⬇️
Files with missing lines Coverage Δ
internal/distributed/proxy/httpserver/utils.go 82.97% <100.00%> (-1.50%) ⬇️
...nternal/distributed/proxy/httpserver/handler_v2.go 90.91% <20.00%> (-1.03%) ⬇️

... and 535 files with indirect coverage changes

smellthemoon pushed a commit to smellthemoon/milvus that referenced this pull request Oct 29, 2024
enhance: refactor createIndex in RESTful API(milvus-io#37235)
dd44001 
Signed-off-by: lixinguo <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@smellthemoon cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

smellthemoon pushed a commit to smellthemoon/milvus that referenced this pull request Oct 29, 2024
enhance: refactor createIndex in RESTful API(milvus-io#37235)
dbf732b 
Signed-off-by: lixinguo <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Oct 29, 2024

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@smellthemoon
Copy link
Contributor Author

rerun go-sdk

smellthemoon pushed a commit to smellthemoon/milvus that referenced this pull request Oct 30, 2024
enhance: refactor createIndex in RESTful API(milvus-io#37235)
c847503 
Signed-off-by: lixinguo <[email protected]>
@mergify mergify bot added the ci-passed label Oct 30, 2024
smellthemoon pushed a commit to smellthemoon/milvus that referenced this pull request Oct 30, 2024
enhance: refactor createIndex in RESTful API(milvus-io#37235)
ab7ec2d 
Signed-off-by: lixinguo <[email protected]>
smellthemoon pushed a commit to smellthemoon/milvus that referenced this pull request Oct 31, 2024
enhance: refactor createIndex in RESTful API(milvus-io#37235)
be12cde 
Signed-off-by: lixinguo <[email protected]>
@mergify mergify bot removed the ci-passed label Nov 5, 2024
@smellthemoon
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Nov 6, 2024
congqixia
congqixia approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 86fd320 into milvus-io:master Nov 7, 2024
17 of 20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Nov 7, 2024
@smellthemoon
enhance: refactor createIndex in RESTful API(#37235) (#37237)
60f9631 
pr: #37235 
2.5: #37236

Signed-off-by: lixinguo <[email protected]>
Co-authored-by: lixinguo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@czs007 czs007 Awaiting requested review from czs007

@xige-16 xige-16 Awaiting requested review from xige-16

Assignees

@congqixia congqixia

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smellthemoon @sre-ci-robot @congqixia