enhance: refactor createIndex in RESTful API(#37235) #37236

smellthemoon · 2024-10-29T03:29:59Z

pr: #37235

mergify · 2024-10-29T03:59:43Z

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify · 2024-10-29T04:01:34Z

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2024-10-29T04:38:55Z

@smellthemoon cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify · 2024-10-29T04:43:42Z

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

sre-ci-robot · 2024-10-29T06:20:05Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smellthemoon
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

internal/distributed/OWNERS
tests/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mergify · 2024-10-29T06:35:10Z

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify · 2024-10-29T06:35:56Z

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

smellthemoon · 2024-10-29T06:44:58Z

/run-cpu-e2e

smellthemoon · 2024-10-29T06:45:05Z

rerun go-sdk

mergify · 2024-10-29T06:48:40Z

@smellthemoon cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

smellthemoon · 2024-10-29T06:49:32Z

rerun cpp-unit-test

mergify · 2024-10-29T06:59:19Z

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2024-10-29T06:59:19Z

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify · 2024-10-29T07:03:02Z

@smellthemoon cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify · 2024-10-29T11:28:12Z

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

codecov · 2024-10-29T11:42:00Z

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.87%. Comparing base (48614f7) to head (371fd4d).
Report is 20 commits behind head on 2.5.

Files with missing lines	Patch %	Lines
...nternal/distributed/proxy/httpserver/handler_v2.go	20.00%	7 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##              2.5   #37236      +/-   ##
==========================================
- Coverage   83.15%   80.87%   -2.29%     
==========================================
  Files        1029     1319     +290     
  Lines      157321   182777   +25456     
==========================================
+ Hits       130819   147815   +16996     
- Misses      21332    29778    +8446     
- Partials     5170     5184      +14

Components	Coverage Δ
Client	`∅ <ø> (∅)`
Core	`66.95% <100.00%> (∅)`
Go	`83.14% <46.66%> (-0.04%)`	⬇️

Files with missing lines	Coverage Δ
internal/distributed/proxy/httpserver/utils.go	`84.52% <100.00%> (+0.05%)`	⬆️
...nternal/distributed/proxy/httpserver/handler_v2.go	`91.49% <20.00%> (-0.45%)`	⬇️

... and 321 files with indirect coverage changes

mergify · 2024-10-30T03:17:11Z

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2024-10-30T05:27:46Z

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2024-10-30T07:39:48Z

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

smellthemoon · 2024-10-30T08:37:39Z

/run-cpu-e2e

mergify · 2024-10-30T09:50:07Z

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

smellthemoon · 2024-10-30T12:14:37Z

/run-cpu-e2e

mergify · 2024-10-30T13:03:52Z

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: lixinguo <[email protected]>

mergify · 2024-10-31T02:57:49Z

@smellthemoon cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

mergify · 2024-10-31T03:41:36Z

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

smellthemoon · 2024-10-31T03:52:59Z

rerun go-sdk

smellthemoon · 2024-10-31T03:53:15Z

rerun cpp-unit-test

pr: #37235 2.5: #37236 Signed-off-by: lixinguo <[email protected]> Co-authored-by: lixinguo <[email protected]>

sre-ci-robot requested review from bigsheeper and czs007 October 29, 2024 03:30

smellthemoon changed the title ~~enhance: refactor createIndex in RESTful API~~ enhance: refactor createIndex in RESTful API(#37235) Oct 29, 2024

sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Oct 29, 2024

mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 29, 2024

smellthemoon force-pushed the cp-2.5-create-index-restful branch from 0ba62aa to 90fa922 Compare October 29, 2024 03:35

smellthemoon mentioned this pull request Oct 29, 2024

enhance: refactor createIndex in RESTful API(#37235) #37237

Merged

smellthemoon force-pushed the cp-2.5-create-index-restful branch from 90fa922 to 44fb368 Compare October 29, 2024 04:04

smellthemoon force-pushed the cp-2.5-create-index-restful branch from 44fb368 to 486cfa9 Compare October 29, 2024 06:19

sre-ci-robot added area/test sig/testing labels Oct 29, 2024

smellthemoon force-pushed the cp-2.5-create-index-restful branch from 486cfa9 to 9266bde Compare October 29, 2024 10:49

smellthemoon force-pushed the cp-2.5-create-index-restful branch from 9266bde to 845b555 Compare October 30, 2024 02:36

smellthemoon force-pushed the cp-2.5-create-index-restful branch from 845b555 to c3912ec Compare October 30, 2024 04:56

smellthemoon force-pushed the cp-2.5-create-index-restful branch from c3912ec to fc65e80 Compare October 30, 2024 06:02

enhance: refactor createIndex in RESTful API

371fd4d

Signed-off-by: lixinguo <[email protected]>

smellthemoon force-pushed the cp-2.5-create-index-restful branch from fc65e80 to 371fd4d Compare October 31, 2024 02:50

mergify bot added the ci-passed label Oct 31, 2024

smellthemoon closed this Nov 6, 2024

sre-ci-robot pushed a commit that referenced this pull request Nov 7, 2024

enhance: refactor createIndex in RESTful API(#37235) (#37237)

60f9631

pr: #37235 2.5: #37236 Signed-off-by: lixinguo <[email protected]> Co-authored-by: lixinguo <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enhance: refactor createIndex in RESTful API(#37235) #37236

enhance: refactor createIndex in RESTful API(#37235) #37236

smellthemoon commented Oct 29, 2024

mergify bot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

sre-ci-robot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

smellthemoon commented Oct 29, 2024

smellthemoon commented Oct 29, 2024

mergify bot commented Oct 29, 2024

smellthemoon commented Oct 29, 2024

mergify bot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

codecov bot commented Oct 29, 2024 •

edited

Loading

mergify bot commented Oct 30, 2024

mergify bot commented Oct 30, 2024

mergify bot commented Oct 30, 2024

smellthemoon commented Oct 30, 2024

mergify bot commented Oct 30, 2024

smellthemoon commented Oct 30, 2024

mergify bot commented Oct 30, 2024

mergify bot commented Oct 31, 2024

mergify bot commented Oct 31, 2024

smellthemoon commented Oct 31, 2024

smellthemoon commented Oct 31, 2024

enhance: refactor createIndex in RESTful API(#37235) #37236

enhance: refactor createIndex in RESTful API(#37235) #37236

Conversation

smellthemoon commented Oct 29, 2024

mergify bot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

sre-ci-robot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

smellthemoon commented Oct 29, 2024

smellthemoon commented Oct 29, 2024

mergify bot commented Oct 29, 2024

smellthemoon commented Oct 29, 2024

mergify bot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

mergify bot commented Oct 29, 2024

codecov bot commented Oct 29, 2024 • edited Loading

Codecov Report

mergify bot commented Oct 30, 2024

mergify bot commented Oct 30, 2024

mergify bot commented Oct 30, 2024

smellthemoon commented Oct 30, 2024

mergify bot commented Oct 30, 2024

smellthemoon commented Oct 30, 2024

mergify bot commented Oct 30, 2024

mergify bot commented Oct 31, 2024

mergify bot commented Oct 31, 2024

smellthemoon commented Oct 31, 2024

smellthemoon commented Oct 31, 2024

codecov bot commented Oct 29, 2024 •

edited

Loading