Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test for DataNodeNum metrics value #25985

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

congqixia
Copy link
Contributor

See also #25984
/kind improvement

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jul 28, 2023
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 28, 2023
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. ci-passed labels Jul 28, 2023
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #25985 (46cf41a) into master (eaf53c7) will decrease coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25985      +/-   ##
==========================================
- Coverage   82.27%   82.25%   -0.02%     
==========================================
  Files         803      803              
  Lines      106888   106889       +1     
==========================================
- Hits        87939    87919      -20     
- Misses      15861    15880      +19     
- Partials     3088     3090       +2     

see 14 files with indirect coverage changes

@jiaoew1991
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 7f51655 into milvus-io:master Jul 31, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants