Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: delete codc deserialize data by stream batch #30407

Merged
merged 2 commits into from
Feb 6, 2024

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Jan 31, 2024

relate: #30404

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 31, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 31, 2024
Copy link
Contributor

mergify bot commented Jan 31, 2024

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 31, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (98adbb3) 80.23% compared to head (7218ef5) 80.25%.
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #30407      +/-   ##
==========================================
+ Coverage   80.23%   80.25%   +0.01%     
==========================================
  Files         965      965              
  Lines      136070   136127      +57     
==========================================
+ Hits       109180   109249      +69     
+ Misses      23171    23159      -12     
  Partials     3719     3719              
Files Coverage Δ
internal/storage/data_codec.go 67.52% <94.28%> (+1.49%) ⬆️
internal/storage/utils.go 64.23% <40.00%> (-0.14%) ⬇️
internal/storage/payload_reader.go 82.78% <80.43%> (-0.34%) ⬇️

... and 14 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 31, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Feb 1, 2024

rerun ut

@aoiasd
Copy link
Contributor Author

aoiasd commented Feb 1, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Feb 1, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Feb 2, 2024

rerun ut

Copy link
Contributor

mergify bot commented Feb 5, 2024

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Feb 6, 2024

rerun ut

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a053715 into milvus-io:master Feb 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants