Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Optimize DescribeIndex to reduce lock contention #30975

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

xiaocai2333
Copy link
Contributor

issue: #29313
issue: #30443
master pr: #30939

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Mar 1, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 98.55072% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.20%. Comparing base (ef84d40) to head (013514d).
Report is 4 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #30975      +/-   ##
==========================================
+ Coverage   82.18%   82.20%   +0.01%     
==========================================
  Files         843      843              
  Lines      121541   121573      +32     
==========================================
+ Hits        99892    99936      +44     
+ Misses      18421    18413       -8     
+ Partials     3228     3224       -4     
Files Coverage Δ
internal/datacoord/meta.go 89.10% <100.00%> (+0.24%) ⬆️
internal/datacoord/index_service.go 94.87% <97.82%> (+0.08%) ⬆️

... and 13 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 1, 2024
@czs007 czs007 added this to the 2.3.11 milestone Mar 4, 2024
@czs007
Copy link
Collaborator

czs007 commented Mar 4, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 38e3d6a into milvus-io:2.3 Mar 4, 2024
14 checks passed
@xiaocai2333 xiaocai2333 deleted the refine_describe_index-2.3 branch May 10, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants