Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [Sparse Float Vector] added some integration tests #31062

Merged
merged 1 commit into from
Apr 10, 2024
Merged

feat: [Sparse Float Vector] added some integration tests #31062

merged 1 commit into from
Apr 10, 2024

Conversation

zhengbuqian
Copy link
Contributor

@zhengbuqian zhengbuqian commented Mar 6, 2024 •
edited
Loading

add some integration tests for sparse float vector support

#29419

@sre-ci-robot sre-ci-robot added area/compilation area/test sig/testing test/integration integration test size/XXL Denotes a PR that changes 1000+ lines. labels Mar 6, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Mar 6, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 6, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 6, 2024

@zhengbuqian ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 6, 2024

@zhengbuqian ut workflow job failed, comment rerun ut can trigger the job again.

@zhengbuqian zhengbuqian mentioned this pull request Mar 8, 2024
Open
1 task
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 8, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 8, 2024

@zhengbuqian ut workflow job failed, comment rerun ut can trigger the job again.

@zhengbuqian
Copy link
Contributor Author

/hold

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 13, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 13, 2024

@zhengbuqian ut workflow job failed, comment rerun ut can trigger the job again.

@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/XXL Denotes a PR that changes 1000+ lines. labels Mar 13, 2024
@zhengbuqian
Copy link
Contributor Author

/unhold

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 13, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 13, 2024

@zhengbuqian ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 14, 2024

@zhengbuqian ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 10, 2024

@zhengbuqian ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 10, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhengbuqian zhengbuqian mentioned this pull request Apr 10, 2024
Merged
@zhengbuqian zhengbuqian mentioned this pull request Apr 10, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Apr 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.82540% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 81.61%. Comparing base (90bed1c) to head (d7ac381).
Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #31062      +/-   ##
==========================================
+ Coverage   81.57%   81.61%   +0.04%     
==========================================
  Files         989      989              
  Lines      121653   121737      +84     
==========================================
+ Hits        99234    99356     +122     
+ Misses      18607    18579      -28     
+ Partials     3812     3802      -10
Files Coverage Δ
internal/proxy/util.go 90.55% <100.00%> (+0.41%) ⬆️
pkg/common/common.go 73.33% <ø> (ø)
tests/integration/util_index.go 67.52% <100.00%> (+1.44%) ⬆️
tests/integration/util_insert.go 73.00% <100.00%> (+2.73%) ⬆️
tests/integration/util_query.go 79.16% <100.00%> (+0.90%) ⬆️
tests/integration/util_schema.go 97.01% <94.44%> (-2.99%) ⬇️

... and 39 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Apr 10, 2024
@czs007
Copy link
Collaborator

czs007 commented Apr 10, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2fdf1a6 into milvus-io:master Apr 10, 2024
15 checks passed
@zhengbuqian zhengbuqian deleted the sparse-v7-pr4-official branch April 10, 2024 12:08
sre-ci-robot pushed a commit that referenced this pull request Apr 10, 2024
@zhengbuqian
feat: [2.4] [Sparse Float Vector] added some integration tests (#32093)
c8aacc6 
add some integration tests for sparse float vector support

#29419

pr: #31062

Signed-off-by: Buqian Zheng <[email protected]>
sre-ci-robot pushed a commit to milvus-io/pymilvus that referenced this pull request Apr 11, 2024
@zhengbuqian
enhance: [2.4] Update hello_hybrid_sparse_dense.py example to include…
7d75517 
… BGE reranker (#2032)

pr: milvus-io/milvus#31062

Signed-off-by: Buqian Zheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@congqixia congqixia Awaiting requested review from congqixia

Assignees

@czs007 czs007

Labels
approved area/compilation area/test ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm sig/testing size/XL Denotes a PR that changes 500-999 lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhengbuqian @czs007 @sre-ci-robot