Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add RBAC functionality to ImportV2 #31298

Merged
merged 5 commits into from
Mar 19, 2024
Merged

feat: Add RBAC functionality to ImportV2 #31298

merged 5 commits into from
Mar 19, 2024

Conversation

bigsheeper
Copy link
Contributor

issue: #31282, #28521

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Mar 15, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Mar 15, 2024
@bigsheeper bigsheeper mentioned this pull request Mar 15, 2024
Open
1 task
@codecov Codecov
Copy link

codecov bot commented Mar 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 81.03%. Comparing base (dc2cdbe) to head (aaf05cb).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #31298      +/-   ##
==========================================
- Coverage   81.08%   81.03%   -0.05%     
==========================================
  Files         980      980              
  Lines      143635   143659      +24     
==========================================
- Hits       116469   116420      -49     
- Misses      23280    23341      +61     
- Partials     3886     3898      +12
Files Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 89.08% <66.66%> (-0.40%) ⬇️

... and 25 files with indirect coverage changes

@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Mar 18, 2024
@bigsheeper bigsheeper mentioned this pull request Mar 18, 2024
Merged
@bigsheeper
Copy link
Contributor Author

rerun ut

sre-ci-robot pushed a commit that referenced this pull request Mar 18, 2024
@bigsheeper
feat: Add RBAC functionality to ImportV2 (#31298) (#31337)
72acd1d 
issue: #31282,
#28521

pr: #31298

---------

Signed-off-by: bigsheeper <[email protected]>
@czs007
Copy link
Collaborator

czs007 commented Mar 19, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 19, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 19, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper
Copy link
Contributor Author

/run-cpu-e2e

@czs007 czs007 added ci-passed manual-pass manually set pass before ci-passed labeled labels Mar 19, 2024
@sre-ci-robot sre-ci-robot merged commit 2b7df47 into milvus-io:master Mar 19, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 czs007 left review comments

@cydrain cydrain Awaiting requested review from cydrain

Assignees

@czs007 czs007

Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm manual-pass manually set pass before ci-passed labeled size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bigsheeper @czs007 @sre-ci-robot