Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix l0 compactor may cause DN from OOM #33554

Merged

fix coding style

89bf086
Select commit
Loading
Failed to load commit list.
Merged

fix: Fix l0 compactor may cause DN from OOM #33554

fix coding style
89bf086
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 6, 2024 in 0s

82.00% (target 77.00%)

View this Pull Request on Codecov

82.00% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 78.12500% with 77 lines in your changes missing coverage. Please review.

Project coverage is 82.00%. Comparing base (2422084) to head (89bf086).
Report is 23 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33554      +/-   ##
==========================================
+ Coverage   81.92%   82.00%   +0.08%     
==========================================
  Files        1015     1008       -7     
  Lines      130247   130404     +157     
==========================================
+ Hits       106700   106935     +235     
+ Misses      19552    19488      -64     
+ Partials     3995     3981      -14     
Files Coverage Δ
internal/datanode/data_node.go 82.20% <ø> (-0.08%) ⬇️
internal/datanode/io/binlog_io.go 90.47% <100.00%> (+4.11%) ⬆️
internal/datanode/data_sync_service.go 77.04% <66.66%> (+10.62%) ⬆️
internal/datanode/io/io_pool.go 58.33% <80.00%> (ø)
internal/datanode/services.go 80.66% <50.00%> (ø)
internal/datanode/compaction/segment_writer.go 83.76% <77.14%> (-2.83%) ⬇️
internal/datanode/compaction/l0_compactor.go 91.12% <91.12%> (ø)
internal/datanode/util/load_stats.go 48.31% <48.31%> (ø)

... and 216 files with indirect coverage changes