Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: record the duration waiting in the proxy queue #34744

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

longjiquan
Copy link
Contributor

fix: #34743

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jul 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Jul 17, 2024
@longjiquan longjiquan added this to the 2.4.7 milestone Jul 17, 2024
Copy link
Contributor

mergify bot commented Jul 17, 2024

@longjiquan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Jul 17, 2024
@longjiquan
Copy link
Contributor Author

rerun ut

@czs007
Copy link
Collaborator

czs007 commented Jul 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

longjiquan added a commit to longjiquan/milvus that referenced this pull request Jul 18, 2024
longjiquan added a commit to longjiquan/milvus that referenced this pull request Jul 18, 2024
longjiquan added a commit to longjiquan/milvus that referenced this pull request Jul 18, 2024
longjiquan added a commit to longjiquan/milvus that referenced this pull request Jul 18, 2024
longjiquan added a commit to longjiquan/milvus that referenced this pull request Jul 18, 2024
longjiquan added a commit to longjiquan/milvus that referenced this pull request Jul 19, 2024
longjiquan added a commit to longjiquan/milvus that referenced this pull request Jul 19, 2024
sre-ci-robot pushed a commit that referenced this pull request Jul 19, 2024
sre-ci-robot pushed a commit that referenced this pull request Jul 19, 2024
Signed-off-by: longjiquan <[email protected]>
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 94.69027% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.90%. Comparing base (d294fdd) to head (6242a1f).
Report is 16 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34744      +/-   ##
==========================================
+ Coverage   80.84%   80.90%   +0.06%     
==========================================
  Files        1175     1185      +10     
  Lines      142066   142724     +658     
==========================================
+ Hits       114849   115472     +623     
+ Misses      22826    22825       -1     
- Partials     4391     4427      +36     
Files Coverage Δ
internal/proxy/task.go 90.43% <100.00%> (+1.45%) ⬆️
internal/proxy/task_alias.go 95.83% <100.00%> (ø)
internal/proxy/task_database.go 98.33% <100.00%> (+2.22%) ⬆️
internal/proxy/task_delete.go 92.62% <100.00%> (+0.08%) ⬆️
internal/proxy/task_index.go 83.74% <100.00%> (+2.29%) ⬆️
internal/proxy/task_scheduler.go 95.42% <100.00%> (+0.07%) ⬆️
internal/proxy/task_search.go 76.83% <ø> (+0.31%) ⬆️
internal/proxy/task_statistic.go 85.16% <100.00%> (+1.78%) ⬆️
pkg/metrics/proxy_metrics.go 100.00% <100.00%> (ø)
internal/proxy/task_insert.go 76.78% <50.00%> (+0.56%) ⬆️
... and 2 more

... and 133 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jul 23, 2024
@czs007
Copy link
Collaborator

czs007 commented Jul 23, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit a2ac84b into milvus-io:master Jul 23, 2024
11 of 12 checks passed
@longjiquan longjiquan deleted the proxy-queue-metric branch July 23, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add metric to track queuing duration of various requests (such as DML, DQL, DDL, etc.) In Proxy
3 participants