fix: keep inner topK to avoid exceeding efSearch #36284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
|
related: #36273 |
|
@czs007 E2e jenkins job failed, comment |
czs007
force-pushed
the
fix_hybrid_topk_main
branch
from
88c6daf
to
7ed7ce4
Compare
czs007
added a commit
that referenced
this pull request
Sep 15, 2024
issue :#36243 pr : #36284 Signed-off-by: zhenshan.cao <[email protected]>
Signed-off-by: zhenshan.cao <[email protected]>
czs007
force-pushed
the
fix_hybrid_topk_main
branch
from
7ed7ce4
to
d6acca5
Compare
sre-ci-robot
added
size/S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #36284 +/- ##
==========================================
- Coverage 82.46% 73.53% -8.94%
==========================================
Files 1271 1271
Lines 149930 150063 +133
==========================================
- Hits 123644 110342 -13302
- Misses 21340 34776 +13436
+ Partials 4946 4945 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: ##36243