Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Unify loaded partition check to delegator #36879

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

congqixia
Copy link
Contributor

Related to #36370

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/M Denotes a PR that changes 30-99 lines. labels Oct 15, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 15, 2024
Signed-off-by: Congqi Xia <[email protected]>
@mergify mergify bot added the ci-passed label Oct 15, 2024
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.52%. Comparing base (b0d5866) to head (55a4cef).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
internal/querynodev2/segments/validate.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36879      +/-   ##
==========================================
+ Coverage   81.51%   81.52%   +0.01%     
==========================================
  Files        1308     1308              
  Lines      156200   156208       +8     
==========================================
+ Hits       127324   127347      +23     
+ Misses      23753    23749       -4     
+ Partials     5123     5112      -11     
Files with missing lines Coverage Δ
internal/querynodev2/delegator/delegator.go 86.84% <100.00%> (+0.24%) ⬆️
internal/querynodev2/segments/retrieve.go 85.57% <100.00%> (ø)
internal/querynodev2/tasks/search_task.go 85.64% <100.00%> (ø)
internal/querynodev2/segments/validate.go 70.27% <50.00%> (-4.09%) ⬇️

... and 28 files with indirect coverage changes

@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit ba25320 into milvus-io:master Oct 15, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants