Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Limit import job number (#36891) #36892

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

bigsheeper
Copy link
Contributor

issue: #36890

pr: #36891

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Oct 15, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 15, 2024
Copy link
Contributor

mergify bot commented Oct 15, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 97.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.83%. Comparing base (2742524) to head (6b0a2b1).
Report is 3 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/datacoord/services.go 90.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36892      +/-   ##
==========================================
+ Coverage   80.63%   83.83%   +3.20%     
==========================================
  Files        1065      798     -267     
  Lines      164519   138468   -26051     
==========================================
- Hits       132652   116082   -16570     
+ Misses      27523    18056    -9467     
+ Partials     4344     4330      -14     
Files with missing lines Coverage Δ
internal/datacoord/import_job.go 100.00% <100.00%> (ø)
internal/datacoord/import_meta.go 95.09% <100.00%> (+1.46%) ⬆️
pkg/util/paramtable/component_param.go 98.33% <100.00%> (+<0.01%) ⬆️
internal/datacoord/services.go 84.89% <90.00%> (+0.30%) ⬆️

... and 294 files with indirect coverage changes

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Oct 18, 2024
@mergify mergify bot removed the ci-passed label Oct 18, 2024
@czs007
Copy link
Collaborator

czs007 commented Oct 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Oct 18, 2024
@sre-ci-robot sre-ci-robot merged commit 4e0f584 into milvus-io:2.4 Oct 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants