Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add checks for bm25 k1 and b in sparse index checker #36907

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

zhengbuqian
Copy link
Contributor

issue: #36883, #35853

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Oct 16, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@b2037c9). Learn more about missing BASE report.
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36907   +/-   ##
=========================================
  Coverage          ?   72.51%           
=========================================
  Files             ?     1308           
  Lines             ?   156228           
  Branches          ?        0           
=========================================
  Hits              ?   113293           
  Misses            ?    37813           
  Partials          ?     5122           
Files with missing lines Coverage Δ
...ndexparamcheck/sparse_float_vector_base_checker.go 100.00% <100.00%> (ø)

@mergify mergify bot added the ci-passed label Oct 16, 2024
@aoiasd
Copy link
Contributor

aoiasd commented Oct 16, 2024

/lgtm

@czs007
Copy link
Collaborator

czs007 commented Oct 16, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 51f13ba into milvus-io:master Oct 16, 2024
15 of 16 checks passed
@zhengbuqian zhengbuqian deleted the doc-in-check-k1-b branch October 17, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants