fix:[2.4]Chunk Id out of range in vector BF search, after the growing index removes the vec chunks. #36938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cqy123456 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”) |
mergify
bot
added
dco-passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.4 #36938 +/- ##
===========================================
+ Coverage 71.91% 84.94% +13.02%
===========================================
Files 1064 797 -267
Lines 140864 116325 -24539
===========================================
- Hits 101305 98808 -2497
+ Misses 35226 13183 -22043
- Partials 4333 4334 +1 |
foxspy
reviewed
Oct 16, 2024
| segment.get_chunk_mutex()); | ||
| // check SyncDataWithIndex() again, in case the vector chunks has been removed. | ||
| if (segment.get_indexing_record().SyncDataWithIndex(field.get_id())) { | ||
| FloatSegmentIndexSearch( |
There was a problem hiding this comment.
return here? it seems that no need to run the following broute force
cqy123456
force-pushed
the
2.4-bf-chunks
branch
from
ce8135a
to
b4ddcd2
Compare
|
/lgtm |
… index removes the vec chunks. Signed-off-by: cqy123456 <[email protected]>
cqy123456
force-pushed
the
2.4-bf-chunks
branch
from
b4ddcd2
to
31bf766
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cqy123456, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sre-ci-robot
pushed a commit
that referenced
this pull request
Oct 18, 2024
…x removes the vec chunks. (#36939) issue: #36871 related pr: #36938 Signed-off-by: cqy123456 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #36871
related pr: #36939