enhance: Batch forward delete when using DirectForward #37076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relatedt milvus-io#36887 DirectFoward streaming delete will cause memory usage explode if the segments number was large. This PR add batching delete API and using it for direct forward implementation. Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot
added
area/internal-api
size/XL
mergify
bot
added
dco-passed
|
@congqixia E2e jenkins job failed, comment |
|
@congqixia go-sdk check failed, comment |
|
/run-cpu-e2e |
|
rerun go-sdk |
|
@congqixia cpp-unit-test check failed, comment |
|
rerun cpp-unit-test |
XuanYang-cn
approved these changes
Oct 24, 2024
| switch { | ||
| case errors.Is(err, merr.ErrSegmentNotFound): | ||
| missingIDs = append(missingIDs, segmentID) | ||
| case err != nil: |
| log.Warn("try to delete data of released segment", zap.Int64s("ids", resp.GetMissingIds())) | ||
| } | ||
| if len(resp.GetFailedIds()) > 0 { | ||
| log.Warn("apply delete for segment failed, marking it offline") |
There was a problem hiding this comment.
make log the segmentIDs here
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Oct 24, 2024
Relatedt milvus-io#36887 DirectFoward streaming delete will cause memory usage explode if the segments number was large. This PR add batching delete API and using it for direct forward implementation. Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Oct 25, 2024
…#37107) Cherry pick from master pr: #37076 Related #36887 DirectFoward streaming delete will cause memory usage explode if the segments number was large. This PR add batching delete API and using it for direct forward implementation. Signed-off-by: Congqi Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relatedt #36887
DirectFoward streaming delete will cause memory usage explode if the segments number was large. This PR add batching delete API and using it for direct forward implementation.