Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Search/Query may failed during updating delegator cache #37174

Merged
merged 3 commits into from
Oct 28, 2024
Merged

fix: Search/Query may failed during updating delegator cache #37174

merged 3 commits into from
Oct 28, 2024

Commits on Oct 28, 2024

  1. fix: Search/Query may failed during updating delegator cache 

    casue init query node client is too heavy, so we remove
updateShardClient from leader mutex, which cause much more concurrent
cornor cases.

This PR delay query node client's init operation until `getClient` is
called, then use leader mutex to protect updating shard client progress
to avoid concurrent issues.

Signed-off-by: Wei Liu <[email protected]>
    @weiliu1031
    weiliu1031 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    d1e3a30 View commit details
    Browse the repository at this point in the history

  2. fix data race 

    Signed-off-by: Wei Liu <[email protected]>
    @weiliu1031
    weiliu1031 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    fee94de View commit details
    Browse the repository at this point in the history

  3. fix review comment 

    Signed-off-by: Wei Liu <[email protected]>
    @weiliu1031
    weiliu1031 committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    c526299 View commit details
    Browse the repository at this point in the history