fix: Check resource when loading deltalogs #37195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to milvus-io#36887 `LoadDeltaLogs` API did not check memory usage. When system is under high delete load pressure, this could result into OOM quit. This PR add resource check for `LoadDeltaLogs` actions and separate internal deltalog loading function with public one. Signed-off-by: Congqi Xia <[email protected]>
mergify
bot
added
dco-passed
|
@congqixia go-sdk check failed, comment |
|
@congqixia E2e jenkins job failed, comment |
|
rerun go-sdk |
|
/run-cpu-e2e |
|
@congqixia E2e jenkins job failed, comment |
|
/run-cpu-e2e |
1 similar comment
|
/run-cpu-e2e |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #37195 +/- ##
==========================================
- Coverage 83.09% 80.87% -2.23%
==========================================
Files 1028 1318 +290
Lines 157213 182604 +25391
==========================================
+ Hits 130634 147673 +17039
- Misses 21395 29765 +8370
+ Partials 5184 5166 -18
|
|
@congqixia E2e jenkins job failed, comment |
Signed-off-by: Congqi Xia <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Oct 29, 2024
Related to milvus-io#36887 `LoadDeltaLogs` API did not check memory usage. When system is under high delete load pressure, this could result into OOM quit. This PR add resource check for `LoadDeltaLogs` actions and separate internal deltalog loading function with public one. --------- Signed-off-by: Congqi Xia <[email protected]>
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Oct 29, 2024
Related to milvus-io#36887 `LoadDeltaLogs` API did not check memory usage. When system is under high delete load pressure, this could result into OOM quit. This PR add resource check for `LoadDeltaLogs` actions and separate internal deltalog loading function with public one. --------- Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Oct 30, 2024
Cherry pick from master pr: #37195 Related to #36887 `LoadDeltaLogs` API did not check memory usage. When system is under high delete load pressure, this could result into OOM quit. This PR add resource check for `LoadDeltaLogs` actions and separate internal deltalog loading function with public one. --------- Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Oct 30, 2024
Cherry pick from master pr: #37195 Related to #36887 `LoadDeltaLogs` API did not check memory usage. When system is under high delete load pressure, this could result into OOM quit. This PR add resource check for `LoadDeltaLogs` actions and separate internal deltalog loading function with public one. --------- Signed-off-by: Congqi Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #36887
LoadDeltaLogsAPI did not check memory usage. When system is under high delete load pressure, this could result into OOM quit.This PR add resource check for
LoadDeltaLogsactions and separate internal deltalog loading function with public one.