-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Return deltadata for DeleteCodec.Deserialize
#37214
enhance: Return deltadata for DeleteCodec.Deserialize
#37214
Conversation
Related to milvus-io#35303 milvus-io#30404 This PR change return type of `DeleteCodec.Deserialize` from `storage.DeleteData` to `DeltaData`, which reduces the memory usage of interface header. Also refine `storage.DeltaData` methods to make it easier to usage. Signed-off-by: Congqi Xia <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@congqixia cpp-unit-test check failed, comment |
@congqixia E2e jenkins job failed, comment |
@congqixia go-sdk check failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #37214 +/- ##
=========================================
Coverage ? 80.84%
=========================================
Files ? 1318
Lines ? 182642
Branches ? 0
=========================================
Hits ? 147664
Misses ? 29801
Partials ? 5177
|
rerun cpp-unit-test |
/run-cpu-e2e |
rerun go-sdk |
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
rerun cpp-unit-test |
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
/lgtm |
) Related to milvus-io#35303 milvus-io#30404 This PR change return type of `DeleteCodec.Deserialize` from `storage.DeleteData` to `DeltaData`, which reduces the memory usage of interface header. Also refine `storage.DeltaData` methods to make it easier to usage. Signed-off-by: Congqi Xia <[email protected]>
#37264) Cherry pick from master pr: #37214 Related to #35303 #30404 This PR change return type of `DeleteCodec.Deserialize` from `storage.DeleteData` to `DeltaData`, which reduces the memory usage of interface header. Also refine `storage.DeltaData` methods to make it easier to usage. Signed-off-by: Congqi Xia <[email protected]>
Related to #35303 #30404
This PR change return type of
DeleteCodec.Deserialize
fromstorage.DeleteData
toDeltaData
, whichreduces the memory usage of interface header.
Also refine
storage.DeltaData
methods to make it easier to usage.