fix: Rectify OffsetOrderedArray contain logic
#37305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to milvus-io#36887 Remove non-hit pk delete record logic does not work since `insert_record_.contain` does not work due to logic problem. Signed-off-by: Congqi Xia <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
|
/lgtm |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #37305 +/- ##
==========================================
- Coverage 83.11% 80.89% -2.23%
==========================================
Files 1029 1319 +290
Lines 157231 182677 +25446
==========================================
+ Hits 130689 147768 +17079
- Misses 21379 29734 +8355
- Partials 5163 5175 +12
|
sre-ci-robot
pushed a commit
that referenced
this pull request
Oct 30, 2024
Cherry pick from master pr: #37305 Related to #36887 Remove non-hit pk delete record logic does not work since `insert_record_.contain` does not work due to logic problem. Signed-off-by: Congqi Xia <[email protected]>
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
Oct 30, 2024
Related to milvus-io#36887 Remove non-hit pk delete record logic does not work since `insert_record_.contain` does not work due to logic problem. Signed-off-by: Congqi Xia <[email protected]>
xiaofan-luan
pushed a commit
to xiaofan-luan/milvus
that referenced
this pull request
Oct 30, 2024
Related to milvus-io#36887 Remove non-hit pk delete record logic does not work since `insert_record_.contain` does not work due to logic problem. Signed-off-by: Congqi Xia <[email protected]>
xiaofan-luan
pushed a commit
to xiaofan-luan/milvus
that referenced
this pull request
Oct 30, 2024
Related to milvus-io#36887 Remove non-hit pk delete record logic does not work since `insert_record_.contain` does not work due to logic problem. Signed-off-by: Congqi Xia <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Oct 31, 2024
Cherry pick from master pr: #37305 Related to #36887 Remove non-hit pk delete record logic does not work since `insert_record_.contain` does not work due to logic problem. Signed-off-by: Congqi Xia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #36887
Remove non-hit pk delete record logic does not work since
insert_record_.containdoes not work due to logic problem.