Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: load deltalogs on demand when doing compactions #37310

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Oct 30, 2024

See #37234

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Oct 30, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 30, 2024
Copy link
Contributor

mergify bot commented Oct 30, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 81.31868% with 17 lines in your changes missing coverage. Please review.

Project coverage is 80.89%. Comparing base (90948e9) to head (93bac9f).
Report is 26 commits behind head on master.

Files with missing lines Patch % Lines
...ternal/datanode/compaction/clustering_compactor.go 35.71% 6 Missing and 3 partials ⚠️
internal/datanode/compaction/mix_compactor.go 83.87% 3 Missing and 2 partials ⚠️
internal/datanode/compaction/merge_sort.go 88.88% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37310      +/-   ##
==========================================
- Coverage   83.11%   80.89%   -2.23%     
==========================================
  Files        1029     1321     +292     
  Lines      157231   183062   +25831     
==========================================
+ Hits       130689   148095   +17406     
- Misses      21379    29780    +8401     
- Partials     5163     5187      +24     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.16% <ø> (∅)
Go 83.13% <78.84%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/datanode/compaction/compactor_common.go 84.40% <100.00%> (-0.25%) ⬇️
internal/datanode/compaction/merge_sort.go 79.13% <88.88%> (+5.60%) ⬆️
internal/datanode/compaction/mix_compactor.go 77.29% <83.87%> (+0.71%) ⬆️
...ternal/datanode/compaction/clustering_compactor.go 67.14% <35.71%> (-0.39%) ⬇️

... and 337 files with indirect coverage changes

@tedxu
Copy link
Contributor Author

tedxu commented Oct 31, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Oct 31, 2024
Signed-off-by: Ted Xu <[email protected]>
@mergify mergify bot removed the ci-passed label Oct 31, 2024
Copy link
Contributor

mergify bot commented Oct 31, 2024

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu
Copy link
Contributor Author

tedxu commented Oct 31, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Oct 31, 2024
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, tedxu, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b792b19 into milvus-io:master Nov 1, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants