Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5]Use ts as msgID for request #37381

Closed
wants to merge 1 commit into from

Conversation

xiaocai2333
Copy link
Contributor

  1. Only search/query requests with a consistency level other than strong will skip timestamp assignment.
  2. MsgID holds little significance for search/query, so duplication is acceptable.

master pr: #37322

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 2, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xiaocai2333
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 2, 2024
Copy link

codecov bot commented Nov 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.85%. Comparing base (116bf50) to head (8cf71bf).
Report is 6 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.5   #37381   +/-   ##
=======================================
  Coverage   80.84%   80.85%           
=======================================
  Files        1322     1322           
  Lines      183234   183230    -4     
=======================================
+ Hits       148143   148147    +4     
+ Misses      29886    29882    -4     
+ Partials     5205     5201    -4     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 66.92% <ø> (ø)
Go 83.11% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/task_scheduler.go 94.52% <100.00%> (-0.06%) ⬇️

... and 17 files with indirect coverage changes

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Nov 2, 2024
Copy link
Contributor

mergify bot commented Nov 2, 2024

@xiaocai2333 cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

rerun cpp-unit-test

@mergify mergify bot added the ci-passed label Nov 2, 2024
@xiaocai2333
Copy link
Contributor Author

/close

@sre-ci-robot
Copy link
Contributor

@xiaocai2333: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants