-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix subscription leak #37382
base: master
Are you sure you want to change the base?
fix: Fix subscription leak #37382
Conversation
Signed-off-by: bigsheeper <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bigsheeper The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #37382 +/- ##
==========================================
+ Coverage 81.03% 83.26% +2.22%
==========================================
Files 1305 1015 -290
Lines 183190 157818 -25372
==========================================
- Hits 148455 131412 -17043
+ Misses 29533 21210 -8323
+ Partials 5202 5196 -6
|
@bigsheeper E2e jenkins job failed, comment |
/run-cpu-e2e |
@bigsheeper E2e jenkins job failed, comment |
/run-cpu-e2e |
@bigsheeper E2e jenkins job failed, comment |
@bigsheeper go-sdk check failed, comment |
@bigsheeper cpp-unit-test check failed, comment |
rerun cpp-unit-test |
rerun go-sdk |
@bigsheeper cpp-unit-test check failed, comment |
rerun cpp-unit-test |
@bigsheeper go-sdk check failed, comment |
@bigsheeper cpp-unit-test check failed, comment |
Close (unsubscribe) the msg stream after completing the
PreCreatedTopic
check to prevent backlog issue.issue: #36021