Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong path spelling when use rootpath in segcore #37453

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

smellthemoon
Copy link
Contributor

@smellthemoon smellthemoon commented Nov 5, 2024

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 5, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 5, 2024
Copy link
Contributor

mergify bot commented Nov 5, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 47.76119% with 35 lines in your changes missing coverage. Please review.

Project coverage is 67.30%. Comparing base (8275e40) to head (eced6ac).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/clustering/KmeansClustering.h 0.00% 20 Missing ⚠️
internal/core/src/storage/FileManager.h 44.44% 10 Missing ⚠️
internal/core/src/storage/Util.cpp 78.26% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37453      +/-   ##
==========================================
- Coverage   67.31%   67.30%   -0.01%     
==========================================
  Files         290      290              
  Lines       25377    25400      +23     
==========================================
+ Hits        17082    17095      +13     
- Misses       8295     8305      +10     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.30% <47.76%> (-0.01%) ⬇️
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/index/InvertedIndexTantivy.cpp 92.77% <100.00%> (ø)
internal/core/src/storage/Util.cpp 76.85% <78.26%> (+0.16%) ⬆️
internal/core/src/storage/FileManager.h 57.77% <44.44%> (-1.20%) ⬇️
internal/core/src/clustering/KmeansClustering.h 0.00% <0.00%> (ø)

Copy link
Contributor

mergify bot commented Nov 5, 2024

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Nov 5, 2024
Copy link
Contributor

mergify bot commented Nov 5, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

@smellthemoon
Copy link
Contributor Author

rerun ut

Copy link
Contributor

mergify bot commented Nov 6, 2024

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 6, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

@smellthemoon
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Nov 6, 2024
Copy link
Contributor

mergify bot commented Nov 6, 2024

@smellthemoon go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 6, 2024

@smellthemoon cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 6, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Nov 7, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Nov 7, 2024
@sre-ci-robot sre-ci-robot merged commit 9b6dd23 into milvus-io:master Nov 7, 2024
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants