Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add rescorer activation function for BM25 #37481

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

zhengbuqian
Copy link
Contributor

issue: #35853

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. area/test sig/testing labels Nov 6, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 6, 2024
Copy link
Contributor

mergify bot commented Nov 6, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 6, 2024

@zhengbuqian cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 6, 2024

@zhengbuqian go-sdk check failed, comment rerun go-sdk can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Nov 6, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.31%. Comparing base (8275e40) to head (433e8b7).
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #37481   +/-   ##
=======================================
  Coverage   67.31%   67.31%           
=======================================
  Files         290      290           
  Lines       25377    25377           
=======================================
  Hits        17082    17082           
  Misses       8295     8295           
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.31% <ø> (ø)
Go ∅ <ø> (∅)

@zhengbuqian
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Nov 7, 2024
@sre-ci-robot sre-ci-robot merged commit 40b770c into milvus-io:master Nov 7, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm sig/testing size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants