Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: regenerate datacoord mockery #37501

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Nov 7, 2024

No description provided.

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 7, 2024
@sunby sunby changed the title fix: regenerate datacoord mockery enhance: regenerate datacoord mockery Nov 7, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 7, 2024
Copy link
Contributor

mergify bot commented Nov 7, 2024

@sunby Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify mergify bot added do-not-merge/missing-related-issue kind/enhancement Issues or changes related to enhancement labels Nov 7, 2024
Copy link
Contributor

mergify bot commented Nov 7, 2024

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@congqixia congqixia removed the kind/bug Issues or changes related a bug label Nov 7, 2024
@congqixia
Copy link
Contributor

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Nov 7, 2024

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@congqixia
Copy link
Contributor

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Nov 7, 2024

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@congqixia
Copy link
Contributor

rerun cpp-unit-test

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.52%. Comparing base (7cfd609) to head (8e94674).
Report is 18 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37501      +/-   ##
==========================================
- Coverage   83.23%   80.52%   -2.72%     
==========================================
  Files        1015     1333     +318     
  Lines      157697   186938   +29241     
==========================================
+ Hits       131260   150523   +19263     
- Misses      21228    31142    +9914     
- Partials     5209     5273      +64     
Components Coverage Δ
Client 52.03% <ø> (∅)
Core 67.30% <47.76%> (∅)
Go 83.24% <75.94%> (-0.02%) ⬇️

see 357 files with indirect coverage changes

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Nov 7, 2024
@sre-ci-robot sre-ci-robot merged commit 7ec449f into milvus-io:master Nov 7, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants