Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Dependencies issue in 2.2.6 #1356

Closed
1 task done
elonzh opened this issue Apr 13, 2023 · 5 comments
Closed
1 task done

[Bug]: Dependencies issue in 2.2.6 #1356

elonzh opened this issue Apr 13, 2023 · 5 comments
Assignees
Labels
kind/bug Something isn't working
Milestone

Comments

@elonzh
Copy link

elonzh commented Apr 13, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

at 22:30:21 ❯ poetry add pymilvus
Using version ^2.2.6 for pymilvus

Updating dependencies
Resolving dependencies... (2.8s)

Writing lock file

Package operations: 4 installs, 0 updates, 0 removals

  • Installing grpcio (1.53.0)
  • Installing mmh3 (3.1.0)
  • Installing ujson (5.7.0)
  • Installing pymilvus (2.2.6)
...
    from pymilvus import Collection, CollectionSchema, DataType, FieldSchema, connections
  File "/home/elonzh/.cache/pypoetry/virtualenvs/unob-hX3-r8Vo-py3.10/lib/python3.10/site-packages/pymilvus/__init__.py", line 13, in <module>
    from .client.stub import Milvus
  File "/home/elonzh/.cache/pypoetry/virtualenvs/unob-hX3-r8Vo-py3.10/lib/python3.10/site-packages/pymilvus/client/stub.py", line 3, in <module>
    from .grpc_handler import GrpcHandler
  File "/home/elonzh/.cache/pypoetry/virtualenvs/unob-hX3-r8Vo-py3.10/lib/python3.10/site-packages/pymilvus/client/grpc_handler.py", line 11, in <module>
    from ..grpc_gen import milvus_pb2_grpc
  File "/home/elonzh/.cache/pypoetry/virtualenvs/unob-hX3-r8Vo-py3.10/lib/python3.10/site-packages/pymilvus/grpc_gen/milvus_pb2_grpc.py", line 5, in <module>
    from . import common_pb2 as common__pb2
  File "/home/elonzh/.cache/pypoetry/virtualenvs/unob-hX3-r8Vo-py3.10/lib/python3.10/site-packages/pymilvus/grpc_gen/common_pb2.py", line 5, in <module>
    from google.protobuf.internal import builder as _builder
ModuleNotFoundError: No module named 'google.protobuf'

Expected Behavior

Just rollback to 2.2.5.

at 22:30:44 ❯ poetry update
Updating dependencies
Resolving dependencies... (86.0s)

Writing lock file

Package operations: 2 installs, 1 update, 0 removals

• Installing protobuf (4.22.3)
• Installing grpcio-tools (1.53.0)
• Updating pymilvus (2.2.6 -> 2.2.5)

Steps/Code To Reproduce behavior

No response

Environment details

No response

Anything else?

No response

@matrixji
Copy link
Contributor

matrixji commented Apr 13, 2023

#1353 remove the grpcio-tools from the dependency list, so we need to add protobuf as a dependency. I'll try to check the required protobuf version range for the generated code.

@matrixji
Copy link
Contributor

unittest OK with the below dependencies:

coverage==7.2.3
grpcio==1.53.0
grpcio-testing==1.53.0
iniconfig==2.0.0
joblib==1.2.0
mmh3==3.1.0
numpy==1.24.2
packaging==23.1
pandas==2.0.0
pluggy==1.0.0
protobuf==3.20.0
pymilvus @ file:///Users/jibin/Working/pymilvus
pytest==7.3.0
pytest-cov==4.0.0
python-dateutil==2.8.2
pytz==2023.3
scikit-learn==1.2.2
scipy==1.10.1
six==1.16.0
threadpoolctl==3.1.0
tzdata==2023.3
ujson==5.7.0

I've also tested with protobuf==4.22.3, and protobuf==4.21.12.
I think we could add "protobuf>=3.20.0" as a dependency

@matrixji
Copy link
Contributor

/assign

matrixji added a commit to matrixji/pymilvus that referenced this issue Apr 14, 2023
@yanliang567
Copy link
Contributor

/assign @XuanYang-cn

sre-ci-robot pushed a commit that referenced this issue Apr 14, 2023
@XuanYang-cn XuanYang-cn added the kind/bug Something isn't working label Apr 17, 2023
XuanYang-cn pushed a commit to XuanYang-cn/pymilvus that referenced this issue Apr 17, 2023
- Improvement support colab (milvus-io#1353)
- Fix missing dependency with protobuf (milvus-io#1358)

Google colab notebook already installed protobuf==3.20.3 at the moment.
And installing grpcio-tools will request a higher version protobuf.
So a restart for notebook kernel is needed.
Indeed grpcio-tools is not mandatory for pymilvus.

Issue: milvus-io#1356

Signed-off-by: yangxuan <[email protected]>
Co-Authored-By: Ji Bin <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Apr 17, 2023
- Improvement support colab (#1353)
- Fix missing dependency with protobuf (#1358)

Google colab notebook already installed protobuf==3.20.3 at the moment.
And installing grpcio-tools will request a higher version protobuf.
So a restart for notebook kernel is needed.
Indeed grpcio-tools is not mandatory for pymilvus.

Issue: #1356

Signed-off-by: yangxuan <[email protected]>
Co-authored-by: Ji Bin <[email protected]>
@XuanYang-cn XuanYang-cn added this to the 2.2.7 milestone Apr 17, 2023
@XuanYang-cn
Copy link
Contributor

see pymilvus==2.2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants