-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Dependencies issue in 2.2.6 #1356
Comments
#1353 remove the grpcio-tools from the dependency list, so we need to add protobuf as a dependency. I'll try to check the required protobuf version range for the generated code. |
unittest OK with the below dependencies:
I've also tested with protobuf==4.22.3, and protobuf==4.21.12. |
/assign |
matrixji
added a commit
to matrixji/pymilvus
that referenced
this issue
Apr 14, 2023
Issue: milvus-io#1356 Signed-off-by: Ji Bin <[email protected]>
/assign @XuanYang-cn |
sre-ci-robot
pushed a commit
that referenced
this issue
Apr 14, 2023
Issue: #1356 Signed-off-by: Ji Bin <[email protected]>
XuanYang-cn
pushed a commit
to XuanYang-cn/pymilvus
that referenced
this issue
Apr 17, 2023
- Improvement support colab (milvus-io#1353) - Fix missing dependency with protobuf (milvus-io#1358) Google colab notebook already installed protobuf==3.20.3 at the moment. And installing grpcio-tools will request a higher version protobuf. So a restart for notebook kernel is needed. Indeed grpcio-tools is not mandatory for pymilvus. Issue: milvus-io#1356 Signed-off-by: yangxuan <[email protected]> Co-Authored-By: Ji Bin <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this issue
Apr 17, 2023
- Improvement support colab (#1353) - Fix missing dependency with protobuf (#1358) Google colab notebook already installed protobuf==3.20.3 at the moment. And installing grpcio-tools will request a higher version protobuf. So a restart for notebook kernel is needed. Indeed grpcio-tools is not mandatory for pymilvus. Issue: #1356 Signed-off-by: yangxuan <[email protected]> Co-authored-by: Ji Bin <[email protected]>
1 task
see pymilvus==2.2.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is there an existing issue for this?
Describe the bug
Expected Behavior
Just rollback to 2.2.5.
at 22:30:44 ❯ poetry update
Updating dependencies
Resolving dependencies... (86.0s)
Writing lock file
Package operations: 2 installs, 1 update, 0 removals
• Installing protobuf (4.22.3)
• Installing grpcio-tools (1.53.0)
• Updating pymilvus (2.2.6 -> 2.2.5)
Steps/Code To Reproduce behavior
No response
Environment details
No response
Anything else?
No response
The text was updated successfully, but these errors were encountered: