Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Support set username and password in system config #1369

Closed
1 task done
xiaofan-luan opened this issue Apr 19, 2023 · 4 comments
Closed
1 task done

[FEATURE]: Support set username and password in system config #1369

xiaofan-luan opened this issue Apr 19, 2023 · 4 comments
Assignees
Milestone

Comments

@xiaofan-luan
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

something like
user= os.getenv("MILVUS_USER")
password= os.getenv("MILVUS_PASSWORD")
so user don't need to hardcode their user and password somewhere

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Anything else?

No response

@XuanYang-cn XuanYang-cn added this to the 2.2.8 milestone Apr 19, 2023
@XuanYang-cn XuanYang-cn self-assigned this Apr 19, 2023
@filip-halt
Copy link
Contributor

filip-halt commented Apr 19, 2023

In regards to this, do we have any plans/ideas for supporting a unified connection that takes username and password into account for milvus and zilliz?

Something along the lines:
connection_string = "username:password@localhost:1930"
or
connection_string = "localhost:19530"
or
connection_string = "username:[email protected]:19538"

Some way to get away all the different options: address vs host/port vs uri/user/password/secure.

What do you think @XuanYang-cn @xiaofan-luan

@xiaofan-luan
Copy link
Contributor Author

that actually make sense to me also.

something like that
username:[email protected]:19538

@filip-halt
Copy link
Contributor

urllib.parse.urlparse() should already do this splitting.

XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this issue Apr 21, 2023
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this issue Apr 21, 2023
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this issue Apr 21, 2023
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this issue Apr 21, 2023
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this issue Apr 21, 2023
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this issue Apr 21, 2023
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this issue Apr 21, 2023
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this issue Apr 21, 2023
sre-ci-robot pushed a commit that referenced this issue Apr 21, 2023
sre-ci-robot pushed a commit that referenced this issue Apr 21, 2023
@XuanYang-cn
Copy link
Contributor

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants