Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Has an utility function to parse if the connection is to Zilliz cloud or opensource Milvus #1371

Open
1 task done
xiaofan-luan opened this issue Apr 19, 2023 · 6 comments · Fixed by #1381
Open
1 task done
Assignees
Milestone

Comments

@xiaofan-luan
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

  1. currently I thought we can based on the connection hostname.
  2. later on we should have an open api for it, that would help on how we can init

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Anything else?

No response

@xiaofan-luan xiaofan-luan changed the title [FEATURE]: Has an utility function to parse if the connection is to zilliz cloud or opensource milvus [FEATURE]: Has an utility function to parse if the connection is to Zilliz cloud or opensource Milvus Apr 19, 2023
@XuanYang-cn XuanYang-cn added this to the 2.2.8 milestone Apr 19, 2023
@longjiquan
Copy link
Contributor

/assign

@filip-halt
Copy link
Contributor

would it look something like utility.get_server_type()->("milvus", "zilliz")?

@longjiquan
Copy link
Contributor

would it look something like utility.get_server_type()->("milvus", "zilliz")?

Make sense.

@longjiquan
Copy link
Contributor

/reopen

@sre-ci-robot sre-ci-robot reopened this Apr 26, 2023
@sre-ci-robot
Copy link

@longjiquan: Reopened this issue.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@longjiquan
Copy link
Contributor

We can close this issue until the feature implemented on the server side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants