Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: PlaceHolderValue type is incorrect when input vector is fp16/bf16 #2004

Closed
1 task done
congqixia opened this issue Mar 27, 2024 · 4 comments
Closed
1 task done

[Bug]: PlaceHolderValue type is incorrect when input vector is fp16/bf16 #2004

congqixia opened this issue Mar 27, 2024 · 4 comments
Assignees
@binbinlv
Labels
kind/bug Something isn't working

Comments

@congqixia
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

When search with bf16/fp16 vector the place holder type is always binary

Expected Behavior

Place holder type shall be exactly the input vector type

Steps/Code To Reproduce behavior

See
https://github.com/milvus-io/pymilvus/blob/b9a10c9c41708d4b4d3735d4d1f76713872e31ba/pymilvus/client/prepare.py#L596-L617

Environment details

- Hardware/Softward conditions (OS, CPU, GPU, Memory):
- Method of installation (Docker, or from source):
- Milvus version (v0.3.1, or v0.4.0):
- Milvus configuration (Settings you made in `server_config.yaml`):

Anything else?

No response
@congqixia congqixia added the kind/bug Something isn't working label Mar 27, 2024
@yanliang567
Copy link
Contributor

/assign @congqixia

@congqixia congqixia removed their assignment Mar 27, 2024
@congqixia
Copy link
Contributor Author

/assign @XuanYang-cn

XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this issue Apr 1, 2024
@XuanYang-cn
fix: Use wrong placeholder type for bf16 and float16
0392dac 
See also: milvus-io#2004

Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn XuanYang-cn mentioned this issue Apr 1, 2024
Merged
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this issue Apr 1, 2024
@XuanYang-cn
fix: [cherry-pick]Use wrong placeholder type for bf16 and float16
8fe4314 
See also: milvus-io#2004

Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn XuanYang-cn mentioned this issue Apr 1, 2024
Merged
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this issue Apr 2, 2024
@XuanYang-cn
fix: Use wrong placeholder type for bf16 and float16
29be11e 
See also: milvus-io#2004

Signed-off-by: yangxuan <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Apr 2, 2024
@XuanYang-cn
fix: Use wrong placeholder type for bf16 and float16 (#2011)
722d2b5 
See also: #2004

---------

Signed-off-by: yangxuan <[email protected]>
sre-ci-robot pushed a commit that referenced this issue Apr 2, 2024
@XuanYang-cn
fix: [cherry-pick]Use wrong placeholder type for bf16 and float16 (#2012
ed6415f 
)

See also: #2004

---------

Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn
Copy link
Contributor

/unassign
/assign @binbinlv
Please help verify

@sre-ci-robot sre-ci-robot assigned binbinlv and unassigned XuanYang-cn Apr 2, 2024
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this issue Apr 9, 2024
@XuanYang-cn
fix: restrict input/search type for vector fields
b630638 
See also: milvus-io#2018, milvus-io#2004, milvus-io#2016

Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn XuanYang-cn mentioned this issue Apr 9, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Apr 10, 2024
@XuanYang-cn
fix: restrict input/search type for vector fields (#2025)
ea2c9c6 
See also: #2018, #2004, #2016

---------

Signed-off-by: yangxuan <[email protected]>
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this issue Apr 10, 2024
@XuanYang-cn
fix: [cherry-pick]restrict input/search type for vector fields (milvu…
b661c26 
…s-io#2025)

See also: milvus-io#2018, milvus-io#2004, milvus-io#2016

---------

Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn XuanYang-cn mentioned this issue Apr 10, 2024
Merged
sre-ci-robot pushed a commit that referenced this issue Apr 10, 2024
@XuanYang-cn
fix: [cherry-pick]restrict input/search type for vector fields (#2025) (
ad1fb25 
#2029)

See also: #2018, #2004, #2016

---------

Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn
Copy link
Contributor

should be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@binbinlv binbinlv

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@XuanYang-cn @yanliang567 @binbinlv @congqixia