Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http handler is not expected to set tcp scheme #496

Closed
XuanYang-cn opened this issue Apr 25, 2021 · 1 comment
Closed

Http handler is not expected to set tcp scheme #496

XuanYang-cn opened this issue Apr 25, 2021 · 1 comment
Assignees
@XuanYang-cn
Labels
kind/bug Something isn't working

Comments

@XuanYang-cn
Copy link
Contributor

pymilvus/milvus/client/http_handler.py

Line 120 in 642af04

_proto = _uri.scheme

This is a bug when parsing uri="tcp://host.port"
@XuanYang-cn XuanYang-cn added the kind/bug Something isn't working label Apr 25, 2021
@XuanYang-cn XuanYang-cn self-assigned this Apr 25, 2021
@XuanYang-cn XuanYang-cn mentioned this issue Apr 25, 2021
Closed
3 tasks
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this issue Apr 25, 2021
@XuanYang-cn
Force using http/https scheme with http-handler
9b9edc5 
Fix: milvus-io#496
See also: milvus-io/milvus#5030

Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn XuanYang-cn mentioned this issue Apr 25, 2021
Merged
wxyucs pushed a commit that referenced this issue Apr 25, 2021
@XuanYang-cn
Force using http/https scheme with http-handler (#497)
84fe3eb 
Fix: #496
See also: milvus-io/milvus#5030

Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn
Copy link
Contributor Author

Done

mergify bot pushed a commit that referenced this issue May 8, 2021
@XuanYang-cn @dependabot
merge pymilvus v1.1.0 release into 1.x (#501)
0506d4a 
* Update support versions (#491)

Signed-off-by: Xiangyu Wang <[email protected]>

* Force using http/https scheme with http-handler (#497)

Fix: #496
See also: milvus-io/milvus#5030

Signed-off-by: yangxuan <[email protected]>

* Bump jinja2 pygments and py (#498)

Bumps:
- jinja2 from 2.10.3 to 2.11.3.
- pygments from 2.5.2 to 2.7.4.
- py from 1.8.1 to 1.10.0.

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Prepare for 1.1.0 (#500)

Signed-off-by: yangxuan <[email protected]>

Co-authored-by: Xiangyu Wang <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this issue May 28, 2021
@XuanYang-cn @dependabot
merge pymilvus v1.1.0 release into 1.x (milvus-io#501)
050a293 
* Update support versions (milvus-io#491)

Signed-off-by: Xiangyu Wang <[email protected]>

* Force using http/https scheme with http-handler (milvus-io#497)

Fix: milvus-io#496
See also: milvus-io/milvus#5030

Signed-off-by: yangxuan <[email protected]>

* Bump jinja2 pygments and py (milvus-io#498)

Bumps:
- jinja2 from 2.10.3 to 2.11.3.
- pygments from 2.5.2 to 2.7.4.
- py from 1.8.1 to 1.10.0.

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Prepare for 1.1.0 (milvus-io#500)

Signed-off-by: yangxuan <[email protected]>

Co-authored-by: Xiangyu Wang <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
XuanYang-cn added a commit to XuanYang-cn/pymilvus that referenced this issue Aug 15, 2021
@XuanYang-cn @dependabot
merge pymilvus v1.1.0 release into 1.x (milvus-io#501)
74d164d 
* Update support versions (milvus-io#491)

Signed-off-by: Xiangyu Wang <[email protected]>

* Force using http/https scheme with http-handler (milvus-io#497)

Fix: milvus-io#496
See also: milvus-io/milvus#5030

Signed-off-by: yangxuan <[email protected]>

* Bump jinja2 pygments and py (milvus-io#498)

Bumps:
- jinja2 from 2.10.3 to 2.11.3.
- pygments from 2.5.2 to 2.7.4.
- py from 1.8.1 to 1.10.0.

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Prepare for 1.1.0 (milvus-io#500)

Signed-off-by: yangxuan <[email protected]>

Co-authored-by: Xiangyu Wang <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@XuanYang-cn XuanYang-cn

Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@XuanYang-cn