Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milvus Client #1374

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Milvus Client #1374

merged 1 commit into from
Apr 28, 2023

Conversation

filip-halt
Copy link
Contributor

@filip-halt filip-halt commented Apr 20, 2023

Looking to add a wrapper around Pymilvus for easier usage.

@filip-halt
Copy link
Contributor Author

filip-halt commented Apr 20, 2023

fixes #1380

@filip-halt filip-halt force-pushed the pymilvus_client branch 2 times, most recently from 00fb70b to db6c2ef Compare April 21, 2023 16:52
@xiaofan-luan
Copy link
Contributor

please squash your commit record into 1 to make the commit history easier to understand.

pymilvus/milvus_client/milvus_client.py Show resolved Hide resolved
pymilvus/milvus_client/milvus_client.py Outdated Show resolved Hide resolved
pymilvus/milvus_client/milvus_client.py Show resolved Hide resolved
pymilvus/milvus_client/milvus_client.py Outdated Show resolved Hide resolved
pymilvus/milvus_client/milvus_client.py Show resolved Hide resolved
pymilvus/milvus_client/milvus_client.py Show resolved Hide resolved
pymilvus/milvus_client/milvus_client.py Show resolved Hide resolved
pymilvus/milvus_client/milvus_client.py Show resolved Hide resolved
pymilvus/milvus_client/milvus_client.py Outdated Show resolved Hide resolved
pymilvus/milvus_client/milvus_client.py Outdated Show resolved Hide resolved
pymilvus/milvus_client/milvus_client.py Show resolved Hide resolved
pymilvus/milvus_client/milvus_client.py Outdated Show resolved Hide resolved
pymilvus/milvus_client/milvus_client.py Show resolved Hide resolved
pymilvus/milvus_client/milvus_client.py Outdated Show resolved Hide resolved
pymilvus/milvus_client/milvus_client.py Outdated Show resolved Hide resolved
pymilvus/milvus_client/milvus_client.py Outdated Show resolved Hide resolved
pymilvus/milvus_client/milvus_client.py Outdated Show resolved Hide resolved
@filip-halt filip-halt force-pushed the pymilvus_client branch 2 times, most recently from 66f5344 to c331cb4 Compare April 24, 2023 18:31
@longjiquan
Copy link
Contributor

@filip-halt could you please solve the code style issues, otherwise this can't be merged automatically.

@longjiquan
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filip-halt, longjiquan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Filip Haltmayer <[email protected]>
@filip-halt filip-halt changed the title [WIP] Milvus Client Milvus Client Apr 27, 2023
@longjiquan
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 673167c into milvus-io:master Apr 28, 2023
XuanYang-cn pushed a commit to XuanYang-cn/pymilvus that referenced this pull request Apr 28, 2023
- Fix incorrect dim error msg (milvus-io#1394)
- Include MilvusClient (milvus-io#1374)

Co-Authored-by: Filip Haltmayer <[email protected]>
Signed-off-by: yangxuan <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Apr 29, 2023
- Fix incorrect dim error msg (#1394)
- Include MilvusClient (#1374)

Signed-off-by: yangxuan <[email protected]>
Co-authored-by: Filip Haltmayer <[email protected]>
Co-authored-by: Filip Haltmayer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants