Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync partiton APIs with collection #1405

Merged
merged 1 commit into from
Apr 27, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pymilvus/client/prepare.py
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ def partition_name(cls, collection_name, partition_name):
def batch_insert_or_upsert_param(cls, collection_name, entities, partition_name, fields_info=None, isInsert=True, **kwargs):
# insert_request.hash_keys and upsert_request.hash_keys won't be filled in client. It will be filled in proxy.

tag = partition_name or "_default" # should here?
tag = partition_name if isinstance(partition_name, str) else "_default" # should here?
request = milvus_types.InsertRequest(collection_name=collection_name, partition_name=tag)

if not isInsert:
Expand Down
1 change: 0 additions & 1 deletion pymilvus/orm/collection.py
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ def __init__(self, name: str, schema: CollectionSchema=None, using: str="default
def __repr__(self):
_dict = {
'name': self.name,
'partitions': self.partitions,
'description': self.description,
'schema': self._schema,
}
Expand Down
Loading