Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

while parse uri, overwrite the db_name with default #1683

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

PowderLi
Copy link
Contributor

@PowderLi PowderLi commented Sep 8, 2023

/kind bug
milvus #26833
milvus #26834

default value user case1(as bug described) user case2 user case 3 user case4
MilvusClient's arguments uri http://localhost:19530 http://localhost:19530 http://localhost:19530/test http://localhost:19530/test http://localhost:19530/test
db_name test default test
connect with milvus server found uri without dbname, use "default" found uri without dbname, use "default" found uri with dbname "test" found uri with dbname "test" found uri with dbname "test"
result correct db_name didn't work corrent uri priority higher corrent
how to fix use db_name "test"

@sre-ci-robot sre-ci-robot added the kind/bug Something isn't working label Sep 8, 2023
@mergify mergify bot added the dco-passed label Sep 8, 2023
@czs007
Copy link
Contributor

czs007 commented Sep 8, 2023

/approve
/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, PowderLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Sep 8, 2023
@sre-ci-robot sre-ci-robot merged commit 41f9dac into milvus-io:2.2 Sep 8, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants