Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change error_code to code #1696

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

jiaoew1991
Copy link
Contributor

Signed-off-by: Enwei Jiao <[email protected]>
@XuanYang-cn
Copy link
Contributor

/hold
for uncompleted

@XuanYang-cn XuanYang-cn added this to the 2.3.2 milestone Sep 15, 2023
@jiaoew1991 jiaoew1991 force-pushed the change-error-code branch 3 times, most recently from 3753d9b to d7863e5 Compare September 19, 2023 06:22
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all the usuage of common_pb2.XXXX

pymilvus/client/grpc_handler.py Outdated Show resolved Hide resolved
pymilvus/client/grpc_handler.py Outdated Show resolved Hide resolved
pymilvus/client/grpc_handler.py Outdated Show resolved Hide resolved
pymilvus/client/grpc_handler.py Outdated Show resolved Hide resolved
@XuanYang-cn
Copy link
Contributor

/unhold

pymilvus/exceptions.py Show resolved Hide resolved
@XuanYang-cn
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiaoew1991, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0ee4e7d into milvus-io:master Sep 25, 2023
9 checks passed
MrPresent-Han pushed a commit to MrPresent-Han/pymilvus that referenced this pull request Sep 26, 2023
MrPresent-Han pushed a commit to MrPresent-Han/pymilvus that referenced this pull request Sep 26, 2023
MrPresent-Han pushed a commit to MrPresent-Han/pymilvus that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants