Modify highlevel delete to not return any value #1777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from version 2.3.2, Milvus no longer includes the primary keys in the result when processing the delete operation with expressions. This change is due to the large amount of data involved. The delete interface no longer returns any results. If no exceptions are thrown, it indicates a successful deletion. However, for backward compatibility, if the primary_keys returned from Milvus is not empty the list of primary keys is still returned. Signed-off-by: zhenshan.cao <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, longjiquan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
XuanYang-cn
requested changes
Nov 10, 2023
| @@ -379,6 +379,15 @@ def delete( | |||
| Delete all the entries based on the pk. If unsure of pk you can first query the collection | |||
| to grab the corresponding data. Then you can delete using the pk_field. | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
The return type should be changed to Optional[List[Union[str, int]]]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from version 2.3.2, Milvus no longer includes the primary keys in the result when processing the delete operation with expressions. This change is due to the large amount of data involved. The delete interface no longer returns any results. If no exceptions are thrown, it indicates a successful deletion. However, for backward compatibility, if the primary_keys returned from Milvus is not empty the list of primary keys is still returned.