Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified example_tls2.py through MilvusClient #2077

Merged
merged 1 commit into from
May 14, 2024

Conversation

nish112022
Copy link
Contributor

It is to make the example consistent with https://milvus.io/docs/tls.md..

@nish112022
Copy link
Contributor Author

@czs007 PTAL. It says above "please assign czs007 after the PR has been reviewed".
/assign @czs007

@nish112022
Copy link
Contributor Author

@XuanYang-cn PTAL.Shall I do something else here?

@nish112022
Copy link
Contributor Author

/assign @XuanYang-cn

@XuanYang-cn
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nish112022, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 502ef37 into milvus-io:master May 14, 2024
9 checks passed
@XuanYang-cn XuanYang-cn added the PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch label May 14, 2024
XuanYang-cn pushed a commit to XuanYang-cn/pymilvus that referenced this pull request May 14, 2024
Fix bug: add enable_dynamic_field in result of DescribeCollection (milvus-io#1949)

1. modified example_tls1.py through MilvusClient (milvus-io#2065)
2. modified example_tls2.py through MilvusClient (milvus-io#2077)
3. It is to make the example consistent with milvus.io docs

Co-Authored-by: zhenshan.cao <[email protected]>
Co-Authored-by: Nischay Yadav <[email protected]>
Signed-off-by: yangxuan <[email protected]>
@XuanYang-cn XuanYang-cn added PR | cherry-picked to 2.x PR already cherry-picked to branch 2.x and removed PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch labels May 14, 2024
sre-ci-robot pushed a commit that referenced this pull request May 14, 2024
Fix bug: add enable_dynamic_field in result of DescribeCollection
(#1949)

1. modified example_tls1.py through MilvusClient (#2065)
2. modified example_tls2.py through MilvusClient (#2077)
3. It is to make the example consistent with milvus.io docs

Signed-off-by: yangxuan <[email protected]>
Co-authored-by: zhenshan.cao <[email protected]>
Co-authored-by: Nischay Yadav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants