Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [2.4] Make load parameter naming normal (#2243) #2244

Merged
merged 2 commits into from
Aug 30, 2024
Merged

enhance: [2.4] Make load parameter naming normal (#2243) #2244

merged 2 commits into from
Aug 30, 2024

Commits on Aug 30, 2024

  1. enhance: Make load parameter naming normal (milvus-io#2243) 

    Previously added parameters for `load` API have leading underscore,
which is misused and copied from `_async` parameter. The leading "_" is
to avoid use python keyword `async` and other parameters do not have to
follow this pattern.

This PR make `load` API support parameter with or without leading
underscore and update related comment. Note that the ones without
leading "_" have higher priority than the ones with it.

Signed-off-by: Congqi Xia <[email protected]>
    @congqixia
    congqixia committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    4a928ed View commit details
    Browse the repository at this point in the history

  2. Fix comment 

    Signed-off-by: Congqi Xia <[email protected]>
    @congqixia
    congqixia committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    b92c316 View commit details
    Browse the repository at this point in the history