Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix the f16 and bf16 dump error & add all type test for csv & csv supports null #2281

Merged
merged 4 commits into from
Oct 21, 2024
Merged

fix: Fix the f16 and bf16 dump error & add all type test for csv & csv supports null #2281

merged 4 commits into from
Oct 21, 2024

Conversation

OxalisCu
Copy link
Contributor

@mergify mergify bot added the dco-passed label Sep 30, 2024
@OxalisCu OxalisCu changed the title [fix] Fix the f16 and bf16 dump error & add all type test for csv fix: Fix the f16 and bf16 dump error & add all type test for csv Sep 30, 2024
@OxalisCu
fix: pass lint
75f84ba 
Signed-off-by: OxalisCu <[email protected]>
tedxu
tedxu reviewed Oct 17, 2024
View reviewed changes
pymilvus/bulk_writer/buffer.py Outdated Show resolved Hide resolved
pymilvus/bulk_writer/buffer.py Outdated Show resolved Hide resolved
@mergify mergify bot added needs-dco and removed dco-passed labels Oct 18, 2024
@OxalisCu OxalisCu changed the title fix: Fix the f16 and bf16 dump error & add all type test for csv fix: Fix the f16 and bf16 dump error & add all type test for csv & csv supports null Oct 18, 2024
@mergify mergify bot added the ci-passed label Oct 18, 2024
@mergify mergify bot added dco-passed and removed needs-dco labels Oct 18, 2024
@tedxu
Copy link

tedxu commented Oct 21, 2024

/lgtm

@XuanYang-cn
Copy link
Contributor

/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OxalisCu, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4f64af7 into milvus-io:master Oct 21, 2024
11 checks passed
@CaoHaiNam CaoHaiNam mentioned this pull request Oct 22, 2024
Open
1 task
@smellthemoon smellthemoon mentioned this pull request Oct 29, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tedxu tedxu tedxu left review comments

@longjiquan longjiquan Awaiting requested review from longjiquan

@wangting0128 wangting0128 Awaiting requested review from wangting0128

Assignees

@tedxu tedxu

Labels
approved ci-passed dco-passed lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OxalisCu @tedxu @XuanYang-cn @sre-ci-robot