HF2 Slate Changes #258
Merged
HF2 Slate Changes #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyangli
pushed a commit
to mwcproject/mwc-wallet
that referenced
this pull request
May 13, 2020
* Update slate version to V3, define PaymentInfoV3 and add needed serialization * rustfmt * add ttl and payment proof info to slate * rustfmt * add documentation for updated fields * doc test fixes
antiochp
pushed a commit
to antiochp/grin-wallet
that referenced
this pull request
Aug 7, 2020
* Update slate version to V3, define PaymentInfoV3 and add needed serialization * rustfmt * add ttl and payment proof info to slate * rustfmt * add documentation for updated fields * doc test fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to include all slate changes for HF2 in a single place. These changes are:
payment_proofstruct as outlined in 0006-payment-proofs.md grin-rfcs#31 - This is an option field and containssender_address- an ed25519 Public keyreceiver_address- an ed25519 Public key, optional as it will be filled at some stage in the exchange process, not necessarily up frontreceiver_signature- secp256k1 Schnorr signature, optional for the same reasonmessageas outlined in the RFC not included, pending (or rather not) based on discussion of the significant drawbacks to including it.ttl_cutoff_heightas described in Improved Wallet State Management grin-rfcs#30Note while it's perfectly possible now to detect and convert between V3 and V2 slates, there's quite a lot of cruft code involved in the conversion and quite a bit of testing effort required, as well as knock-on checks that will be required when implementing the RFC functionality, all of which becomes a bit of a wasted effort given that everyone will need to upgrade anyhow at HF2 time. Therefore I've just elected to keep it simple and just include compatibility with the latest slate format, V3. Unfortunately, this will mean master will be unusable with older wallets once this PR is merged.