-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slatepack OwnerAPI Changes #421
Conversation
Updated top comment, should be ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed for general slatepack logic in OwnerAPI, a few non-critical notes:
-
is it worth splitting out
get_slatepack_secret_edkey()
andget_slatepack_secret_xkey()
in the API in case someone wants to do encryption/decryption at a different layer? or is that too much complexity/opportunity for confusion in the API calls for the convenience? -
before beta we will want to add stricter validation for anything exposed in libwallet
This is coming together nicely, can't wait to start hitting the command-line workflow.
I hope some others are watching this to see beastplume in action
This can be added at any time if anyone calls for it, but might as well keep it simple for the moment. |
* change all user-facing instances of addresses to a SlatepackAddress * finish renaming get_slatepack_address + documentation * get_slatepack_secret_key OwnerRPC implementation and test * add owner api functions * OwnerRPC functions + doctests * add explicit slatepack API tests to exercise encryption * update api function names to better reflect RFC
This PR aims to:
In detail:
get_public_proof_address
Owner API function toget_slatepack_address
and return a slatepack address instead.proof_address_from_onionv3
function from the Owner API as it's no longer neededinit_send_tx
and other places become a slatepack address.New API functions are:
create_slatepack_message
- returns an (optionally encrypted) armored slatepack string from a slateslate_from_slatepack_message
- extracts the slate from the given slatepack string, attempting to decrypt from a range of deriviation indices if necessary (takes a vec instead of a single value for future multiple-address use)decode_slatepack_message
- convenience function that returns the Slatepack struct itself, which can be viewed as json.Notes: