Fix kernel history verification #1218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only rewind kernels to avoid requiring proper bitmap extraction. Also avoids maintaining bitmap data for kernels by introducing a "prunable" flag on PMMR backend.
|
Cool, makes more sense than the bool flags on rewind |
antiochp
reviewed
Jul 5, 2018
| migrate_rm_log(&mut leaf_set, &rm_log, &prune_list, last_pos)?; | ||
| } | ||
| let prune_list = PruneList::open(format!("{}/{}", data_dir, PMMR_PRUN_FILE))?; | ||
| let leaf_set = LeafSet::open(leaf_set_path.clone())?; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
antiochp
reviewed
Jul 5, 2018
| @@ -57,6 +57,7 @@ where | |||
| T: PMMRable, | |||
| { | |||
| data_dir: String, | |||
| prunable: bool, | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This was referenced Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only rewind kernels to avoid requiring proper bitmap extraction.
Also avoids maintaining bitmap data for kernels by introducing a
"prunable" flag on PMMR backend. Finally, clean up some testnet2
migration code.
Fixes #1207. Related to #1214.