-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update croaring #3233
Update croaring #3233
Conversation
🙈 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 👍
I'd like to spend some time testing this locally, just to be confident croaring bitmap serialization has not changed in some unexpected way or anything.
Will try and get to this tomorrow.
Testing this right now. |
Might be worth just going through the updates again to resolve the conflicts, |
5c011b9
to
aa1ebd5
Compare
Should be good now @antiochp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 lets get this merged in once tests pass.
Let's see if it fix the CI issues.